The task is completed #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim2310
suggested changes
Aug 25, 2023
src/generateNumber.js
Outdated
Comment on lines
5
to
17
| module.exports.generateNumber = () => { | ||
| const digitsArray = []; | ||
|
|
||
| while (digitsArray.length < NUM_LENGTH) { | ||
| const numToPush = Math.floor(Math.random() * 10); | ||
|
|
||
| if (!digitsArray.includes(numToPush)) { | ||
| digitsArray.push(numToPush); | ||
| } | ||
| } | ||
|
|
||
| return digitsArray.join(''); | ||
| }; |
There was a problem hiding this comment.
you func cant create number with duplicate number and can create number that start from 0, that not so logic
src/validateNumber.js
Outdated
Comment on lines
7
to
9
| if (number[i] === number[i - 1]) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
this redundant but why do you think that the same number will be placed only together
src/bullsAndCows.js
Outdated
Comment on lines
11
to
23
| for (let i = 0; i < NUM_LENGTH; i++) { | ||
| const isBull = enteredNumberCopy[0] === numberToGuessCopy[0]; | ||
| const isCow = numberToGuess.includes(enteredNumberCopy[0]); | ||
|
|
||
| if (isBull) { | ||
| bullsCount++; | ||
| } else if (isCow) { | ||
| cowsCount++; | ||
| } | ||
|
|
||
| numberToGuessCopy.shift(); | ||
| enteredNumberCopy.shift(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (let i = 0; i < NUM_LENGTH; i++) { | |
| const isBull = enteredNumberCopy[0] === numberToGuessCopy[0]; | |
| const isCow = numberToGuess.includes(enteredNumberCopy[0]); | |
| if (isBull) { | |
| bullsCount++; | |
| } else if (isCow) { | |
| cowsCount++; | |
| } | |
| numberToGuessCopy.shift(); | |
| enteredNumberCopy.shift(); | |
| } | |
| for (let i = 0; i < NUM_LENGTH; i++) { | |
| const isBull = enteredNumberCopy[0] === numberToGuessCopy[i]; | |
| const isCow = numberToGuess.includes(enteredNumberCopy[i]); | |
| if (isBull) { | |
| bullsCount++; | |
| } else if (isCow) { | |
| cowsCount++; | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.