Created bulls and cows game #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voievodik
approved these changes
Oct 2, 2023
ArtemTeslenko
suggested changes
Oct 3, 2023
src/app.js
Outdated
| return; | ||
| } | ||
|
|
||
| const searchedNumber = generateNumber(); |
There was a problem hiding this comment.
if user did not win, this number will be generated again and overwrite? In this case it is possible to win only by guessing all the numbers at once.
Moroz-Dmytro
suggested changes
Oct 10, 2023
src/app.js
Outdated
|
|
||
| function gameStart() { | ||
| terminal.question('Enter a number: ', (userInput) => { | ||
| if (userInput.length !== 4 || !Number(userInput)) { |
src/app.js
Outdated
| terminal.question('Enter a number: ', (userInput) => { | ||
| if (userInput.length !== 4 || !Number(userInput)) { | ||
| console.log('Invalid number, please enter a 4 different digits'); | ||
| terminal.question('Enter a number: ', gameStart); |
There was a problem hiding this comment.
Suggested change
| terminal.question('Enter a number: ', gameStart); | |
| gameStart(); |
src/checkAnswer.js
Outdated
|
|
||
| const userNumberArr = userNumber.split(''); | ||
|
|
||
| for (let i = 0; i < 4; i++) { |
src/checkAnswer.js
Outdated
Comment on lines
10
to
11
| if (searchedNumber.includes(userNumberArr[i])) { | ||
| if (searchedNumber.indexOf(userNumberArr[i]) === i) { |
src/checkAnswer.js
Outdated
| } | ||
| } | ||
|
|
||
| return [bulls, cows]; |
There was a problem hiding this comment.
Better to return object
So when you do destructuring order doesn't matter
src/numberGenerator.js
Outdated
| 'use strict'; | ||
|
|
||
| function generateNumber() { | ||
| return Math.floor(1000 + Math.random() * 9000).toString(); |
Moroz-Dmytro
suggested changes
Oct 11, 2023
src/app.js
Outdated
|
|
||
| function gameStart() { | ||
| terminal.question('Enter a number: ', (userInput) => { | ||
| if (userInput.length !== 4 || !Number(userInput)) { |
src/app.js
Outdated
| return; | ||
| } | ||
|
|
||
| const [bulls, cows] = checkAnswer(searchedNumber, userInput); |
There was a problem hiding this comment.
Does it work correctly now? You return object, not array
Moroz-Dmytro
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.