Develop #250
Open
Develop #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge argument name for question callback
Moroz-Dmytro
suggested changes
Oct 10, 2023
src/generateNumber.js
Outdated
Comment on lines
5
to
7
| function generateNumber() { | ||
| return Math.round(Math.random() * (MAX_NUMBER - MIN_NUMBER) + MIN_NUMBER); | ||
| } |
There was a problem hiding this comment.
Your function doesn't generate number with different digits
src/app.js
Outdated
|
|
||
| function askQuestion() { | ||
| terminal.question(QUESTION, (userNumber) => { | ||
| if (userNumber.length !== EXPECTED_NUMBER_LENGTH) { |
There was a problem hiding this comment.
You should also check if user entered number with different digits
…s, create validate input module
Moroz-Dmytro
approved these changes
Oct 10, 2023
src/validateInput.js
Outdated
Comment on lines
5
to
12
| function validateInput(input) { | ||
| const inputSplited = input.split(''); | ||
| const inputSet = new Set(inputSplited); | ||
| const hasValidLength = inputSplited.length === EXPECTED_NUMBER_LENGTH; | ||
| const hasDistinctDigits = inputSplited.length === inputSet.size; | ||
|
|
||
| return hasValidLength && hasDistinctDigits; | ||
| }; |
There was a problem hiding this comment.
Also you need to check if user entered only numbers
If user enter 123q your game will never finish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
Bulls and cowsgame