create cli game #252
Open
create cli game #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polinavafik
approved these changes
Oct 8, 2023
src/constants.js
Outdated
Comment on lines
6
to
10
| = 'You printed something wrong (>_<). Pwease, try again (ﾉ◕ヮ◕)ﾉ'; | ||
| const WELCOME_MESSAGE | ||
| = `Enter ${gameNumberSize} digits pwease (◕‿◕✿): `; | ||
| const VICTORY_MESSAGE | ||
| = 'Wow, you won! (づ ◕‿◕ )づ'; |
Moroz-Dmytro
suggested changes
Oct 9, 2023
src/constants.js
Outdated
| @@ -0,0 +1,17 @@ | |||
| 'use strict'; | |||
|
|
|||
| const gameNumberSize = 4; | |||
src/generateFixedSizeNumber.js
Outdated
Comment on lines
7
to
12
| for (let i = 0; i < length; i++) { | ||
| const randomIndex = Math.floor(Math.random() * digits.length); | ||
|
|
||
| number += digits[randomIndex]; | ||
| digits = digits.slice(0, randomIndex) + digits.slice(randomIndex + 1); | ||
| } |
There was a problem hiding this comment.
Would be better if you will generate your number like this const randomDigit = Math.floor(Math.random() * 10);
In this case you don't need additional variable and operations with slice, but your solution is interesting 👍
src/app.js
Outdated
| if (gameNumber === userNumber) { | ||
| console.log(VICTORY_MESSAGE); | ||
| break; | ||
| } else { |
Moroz-Dmytro
approved these changes
Oct 10, 2023
| const secret = realNumber.toString(10).split(''); | ||
| const guess = playerNumber.toString(10).split(''); | ||
|
|
||
| for (let i = 0; i < 4; i++) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.