add task solution #425
Open
add task solution #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Great job on implementing the core functionality! 🎉 While the game logic works well, adding feedback for the number of bulls and cows after each guess would enhance the user experience. Keep up the good work and consider this improvement for the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
Comment on lines
+22
to
+23
|
|
||
| const { bulls } = getBullsAndCows(secretNumber, userInput); |
There was a problem hiding this comment.
The code correctly calculates the number of bulls and cows, but it does not provide any feedback to the user. Consider adding a console.log statement to inform the user about the number of bulls and cows after each guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.