-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #253
base: master
Are you sure you want to change the base?
solution #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution is ok, but there is some tiny comment.
app/main.py
Outdated
age = IntegerRange(0, 150) | ||
weight = IntegerRange(0, 300) | ||
height = IntegerRange(0, 300) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know to be honest, I just decided to complete a task that I didn't solve before and this part of the code was done a few months ago)
app/main.py
Outdated
self.max_amount = max_amount | ||
self.name = None | ||
|
||
def __get__(self, instance: Visitor, owner: Any) -> dict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid return typehint
+
specify owner's type
app/main.py
Outdated
) | ||
instance.__dict__[self.name] = value | ||
|
||
def __set_name__(self, owner: Any, name: str) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specify owner's type
app/main.py
Outdated
|
||
|
||
class Slide: | ||
pass | ||
def __init__(self, name: int, limitation_class: Callable) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid limitation_class typehint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix flake8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
No description provided.