Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #253

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

solution #253

wants to merge 5 commits into from

Conversation

mblazhko
Copy link

No description provided.

Copy link

@YukihiroSM YukihiroSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution is ok, but there is some tiny comment.

app/main.py Outdated
Comment on lines 30 to 33
age = IntegerRange(0, 150)
weight = IntegerRange(0, 300)
height = IntegerRange(0, 300)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need these?

Copy link
Author

@mblazhko mblazhko Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know to be honest, I just decided to complete a task that I didn't solve before and this part of the code was done a few months ago)

app/main.py Outdated
self.max_amount = max_amount
self.name = None

def __get__(self, instance: Visitor, owner: Any) -> dict:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid return typehint
+
specify owner's type

app/main.py Outdated
)
instance.__dict__[self.name] = value

def __set_name__(self, owner: Any, name: str) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify owner's type

app/main.py Outdated


class Slide:
pass
def __init__(self, name: int, limitation_class: Callable) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid limitation_class typehint

Copy link

@Bohdan-Salamakha Bohdan-Salamakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1

Copy link

@Bohdan-Salamakha Bohdan-Salamakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix flake8

Copy link

@EdAlekseiev EdAlekseiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants