Solution #270
Open
Solution #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsmutok
suggested changes
Aug 20, 2023
| self.max_amount = max_amount | ||
|
|
||
| def __get__(self, instance: object, owner: type) -> None: | ||
| return instance.__dict__[self.name] |
| if not self.min_amount <= value <= self.max_amount: | ||
| raise ValueError(f"{self.name} must be between " | ||
| f"{self.min_amount} and {self.max_amount}") | ||
| instance.__dict__[self.name] = value |
There was a problem hiding this comment.
RecursionError: maximum recursion depth exceeded
Куча таких ошибок с setattr и getattr
There was a problem hiding this comment.
In this case you need have two different names: public and protected
|
RecursionError: maximum recursion depth exceeded |
ArsenPidhoretskyi
suggested changes
Aug 21, 2023
| self.max_amount = max_amount | ||
|
|
||
| def __get__(self, instance: object, owner: type) -> None: | ||
| return instance.__dict__[self.name] |
| if not self.min_amount <= value <= self.max_amount: | ||
| raise ValueError(f"{self.name} must be between " | ||
| f"{self.min_amount} and {self.max_amount}") | ||
| instance.__dict__[self.name] = value |
There was a problem hiding this comment.
In this case you need have two different names: public and protected
| instance.__dict__[self.name] = value | ||
|
|
||
| def __set_name__(self, owner: type, name: str) -> None: | ||
| self.name = name |
There was a problem hiding this comment.
Suggested change
| self.name = name | |
| self.name = f"_{name}" |
Comment on lines
+29
to
+31
| age: IntegerRange = IntegerRange(0, 150) | ||
| weight: IntegerRange = IntegerRange(0, 500) | ||
| height: IntegerRange = IntegerRange(0, 300) |
There was a problem hiding this comment.
This is redundant. Remove this lines
Comment on lines
+40
to
+42
| @abstractmethod | ||
| def validate(self, visitor: Visitor) -> bool: | ||
| pass |
|
|
||
|
|
||
| class ChildrenSlideLimitationValidator(SlideLimitationValidator): | ||
| pass | ||
| def __init__(self) -> None: | ||
| super().__init__(age=(4, 14), weight=(20, 50), height=(80, 120)) |
There was a problem hiding this comment.
age, weight, height must be class attribute as IntegerRange
|
|
||
|
|
||
| class Slide: | ||
| pass | ||
| def __init__(self, name: str, limitation_class: type) -> None: |
There was a problem hiding this comment.
type of what? Provide inner type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.