solution #274
Closed
solution #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Aug 22, 2023
app/main.py
Outdated
Comment on lines
41
to
42
| def __init__(self, age: int, weight: int, height: int) -> None: | ||
| super().__init__(age, weight, height) |
There was a problem hiding this comment.
These lines are not needed. Remove them
app/main.py
Outdated
Comment on lines
50
to
51
| def __init__(self, age: int, weight: int, height: int) -> None: | ||
| super().__init__(age, weight, height) |
There was a problem hiding this comment.
These lines are not needed. Remove them
app/main.py
Outdated
| def __init__( | ||
| self, | ||
| name: str, | ||
| limitation_class: SlideLimitationValidator |
There was a problem hiding this comment.
It accepts type, not instance
ArsenPidhoretskyi
suggested changes
Aug 22, 2023
app/main.py
Outdated
Comment on lines
52
to
54
| limitation_class: ( | ||
| ChildrenSlideLimitationValidator | AdultSlideLimitationValidator | ||
| ) |
There was a problem hiding this comment.
It accepts type of SlideLimitationValidator, not instances
vasylhnatiuk
suggested changes
Aug 22, 2023
app/main.py
Outdated
| self.min_amount = min_amount | ||
| self.max_amount = max_amount | ||
|
|
||
| def __set_name__(self, instance, name: str) -> None: # noqa |
There was a problem hiding this comment.
noqa? why you need it? delete please
There was a problem hiding this comment.
Do you can explain me how write correct type hint for descriptor's methods?
There was a problem hiding this comment.
object is a good idea for annotation
vasylhnatiuk
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.