Solution #282
Open
Solution #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlejviki
suggested changes
Sep 12, 2023
app/main.py
Outdated
|
|
||
| def __set__(self, instance: Callable, value: int) -> None: | ||
| if value in range(self.min_value, self.max_value + 1): | ||
| setattr(instance, self.protected_name, True) |
There was a problem hiding this comment.
you need to set the value to the attribute, not True or False
app/main.py
Outdated
| def __set__(self, instance: Callable, value: int) -> None: | ||
| if value in range(self.min_value, self.max_value + 1): | ||
| setattr(instance, self.protected_name, True) | ||
| else: |
There was a problem hiding this comment.
Maybe you can consider a different approach to solve this task. You can raise ValueError in case if the value is not valid, and in the def can_access method you can catch the error using try/except blocks.
|
is it ok? |
viktoria-rybenchuk
suggested changes
Sep 14, 2023
app/main.py
Outdated
|
|
||
| def __set__(self, instance: Callable, value: int) -> None: | ||
| if value not in range(self.min_value, self.max_value + 1): | ||
| raise ValueError |
There was a problem hiding this comment.
When raising a ValueError, provide a meaningful and descriptive error message.
Bohdan-Salamakha
suggested changes
Sep 16, 2023
app/main.py
Outdated
| def __set_name__(self, owner: SlideLimitationValidator, name: str) -> None: | ||
| self.protected_name = "_" + name | ||
|
|
||
| def __get__(self, instance: Callable, objtype: None = None) -> bool: |
app/main.py
Outdated
|
|
||
|
|
||
| class Slide: | ||
| pass | ||
| def __init__(self, name: str, limitation_class: Callable) -> None: |
There was a problem hiding this comment.
specify the limitation_class typehint
|
there is some issue with the type annotation in the "can_access" method flake8 says that everything is ok but IDE underlines it as: "'SlideLimitationValidator' object is not callable " |
Bohdan-Salamakha
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.