Solution #285
Open
Solution #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasylhnatiuk
suggested changes
Sep 12, 2023
app/main.py
Outdated
| self.limitation_class = limitation_class | ||
|
|
||
| def can_access(self, client: Visitor) -> bool: | ||
| return len(self.limitation_class( |
There was a problem hiding this comment.
why do you use dict?it is strange logic. it would be better to use try-except here
app/main.py
Outdated
| pass | ||
| def __init__(self, | ||
| name: str, | ||
| limitation_class: SlideLimitationValidator |
There was a problem hiding this comment.
Suggested change
| limitation_class: SlideLimitationValidator | |
| limitation_class: Type[SlideLimitationValidator] |
app/main.py
Outdated
| return getattr(instance, self.protected_name) | ||
|
|
||
| def __set__(self, instance: callable, value: int) -> None: | ||
| if value in range(self.min_amount, self.max_amount + 1): |
There was a problem hiding this comment.
and raise here ValueError if value not in range
|
Added raise ValueError to IntegerRange.set, added try-except to Slide.can_access method |
vasylhnatiuk
suggested changes
Sep 12, 2023
| self.limitation_class(client.age, client.height, client.weight) | ||
| return True | ||
| except ValueError: | ||
| return False |
There was a problem hiding this comment.
Suggested change
| return False | |
| return False | |
| return True |
app/main.py
Outdated
| def can_access(self, client: Visitor) -> bool: | ||
| try: | ||
| self.limitation_class(client.age, client.height, client.weight) | ||
| return True |
vasylhnatiuk
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pycharm highlights limitation_class: SlideLimitationValidator and warns that 'SlideLimitationValidator' object is not callable, but the code passes all tests