task completed (1) #287
Open
task completed (1) #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsmutok
suggested changes
Sep 18, 2023
app/main.py
Outdated
| return instance.__dict__[self.name] | ||
|
|
||
| def __set__(self, instance: object, value: int) -> None: | ||
| instance.__dict__[self.name] = value |
app/main.py
Outdated
Comment on lines
46
to
48
| super().__init__(age=IntegerRange(4, 14), | ||
| weight=IntegerRange(20, 50), | ||
| height=IntegerRange(80, 120)) |
There was a problem hiding this comment.
Suggested change
| super().__init__(age=IntegerRange(4, 14), | |
| weight=IntegerRange(20, 50), | |
| height=IntegerRange(80, 120)) | |
| age=IntegerRange(4, 14), | |
| weight=IntegerRange(20, 50), | |
| height=IntegerRange(80, 120) |
ArsenPidhoretskyi
suggested changes
Sep 19, 2023
app/main.py
Outdated
| @@ -2,24 +2,65 @@ | |||
|
|
|||
|
|
|||
| class IntegerRange: | |||
| pass | |||
| def __init__(self, min_amount: int, max_amount: int) -> None: | |||
| self.name = None | |||
app/main.py
Outdated
Comment on lines
10
to
14
| def __get__(self, instance: object, owner: object) -> int: | ||
| return instance.name | ||
|
|
||
| def __set__(self, instance: object, value: int) -> None: | ||
| instance.name = value |
There was a problem hiding this comment.
Wrong realization, validation must be into set method
Also instance.name will not return proper value
app/main.py
Outdated
Comment on lines
34
to
41
| def validate(self, visitor: Visitor) -> bool: | ||
| if (self.age.min_amount <= visitor.age <= self.age.max_amount | ||
| and (self.weight.min_amount <= visitor.weight <= ( | ||
| self.weight.max_amount)) | ||
| and (self.height.min_amount <= visitor.height <= ( | ||
| self.height.max_amount))): | ||
| return True | ||
| return False |
app/main.py
Outdated
|
|
||
|
|
||
| class Slide: | ||
| pass | ||
| def __init__(self, name: str, limitation_class: object) -> None: |
There was a problem hiding this comment.
limitation_class is type of SlideLimitationValidator
There was a problem hiding this comment.
Suggested change
| def __init__(self, name: str, limitation_class: object) -> None: | |
| def __init__(self, name: str, limitation_class: type[SlideLimitationValidator]) -> None: |
app/main.py
Outdated
| pass | ||
| def __init__(self, name: str, limitation_class: object) -> None: | ||
| self.name = name | ||
| self.limitation_class = limitation_class() |
ArsenPidhoretskyi
suggested changes
Jan 9, 2024
app/main.py
Outdated
Comment on lines
10
to
14
| def __get__(self, instance: object, owner: object) -> int: | ||
| return instance.name | ||
|
|
||
| def __set__(self, instance: object, value: int) -> None: | ||
| instance.name = value |
|
|
ArsenPidhoretskyi
suggested changes
Jan 10, 2024
app/main.py
Outdated
Comment on lines
19
to
20
| self.name = name | ||
| self.name = name |
There was a problem hiding this comment.
This two lines are redundant
app/main.py
Outdated
|
|
||
|
|
||
| class Slide: | ||
| pass | ||
| def __init__(self, name: str, limitation_class: object) -> None: |
There was a problem hiding this comment.
Suggested change
| def __init__(self, name: str, limitation_class: object) -> None: | |
| def __init__(self, name: str, limitation_class: type[SlideLimitationValidator]) -> None: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.