Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #289

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #289

wants to merge 3 commits into from

Conversation

Artemh59
Copy link

No description provided.

Copy link

@pavlejviki pavlejviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix type annotations

app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
Artemh59 and others added 2 commits September 20, 2023 14:27
Co-authored-by: Viktoria Pavlej <[email protected]>
Co-authored-by: Viktoria Pavlej <[email protected]>
Copy link

@pavlejviki pavlejviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the type annotations in all methods, but overall well done and approved

def __get__(self, instance: object, owner: type) -> int:
return getattr(instance, self.protected_name)

def __set__(self, instance: Any, value: int) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __set__(self, instance: Any, value: int) -> None:
def __set__(self, instance: object, value: int) -> None:

self.min_amount = min_amount
self.max_amount = max_amount

def __set_name__(self, owner: Any, name: str) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __set_name__(self, owner: Any, name: str) -> None:
def __set_name__(self, owner: type, name: str) -> None:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants