Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #574

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #574

wants to merge 2 commits into from

Conversation

Anatolik-ua
Copy link

No description provided.

app/main.py Outdated
Comment on lines 63 to 68
def validate(self, visitor: Visitor) -> bool:
return (self.age.min_amount <= visitor.age <= self.age.max_amount
and self.weight.min_amount <= visitor.weight
<= self.weight.max_amount
and self.height.min_amount <= visitor.height
<= self.height.max_amount)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRY
don't repeat yourself

app/main.py Outdated
Comment on lines 52 to 56
return (self.age.min_amount <= visitor.age <= self.age.max_amount
and self.weight.min_amount <= visitor.weight
<= self.weight.max_amount
and self.height.min_amount <= visitor.height
<= self.height.max_amount)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRY
don't repeat yourself

Copy link

@vsmutok vsmutok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants