Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #588

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 47 additions & 5 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,25 +1,67 @@
from abc import ABC
from typing import Any


class IntegerRange:
pass
def __init__(self, min_amount: int, max_amount: int) -> None:
self.min_amount = min_amount
self.max_amount = max_amount

def __get__(self, instance: Any, owner: Any) -> Any:
return getattr(instance, self.protected_name)

def __set__(self, instance: Any, value: int) -> Any:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The annotation is incorrect.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __set__(self, instance: Any, value: int) -> Any:
def __set__(self, instance: object, value: int) -> Any:

if not isinstance(value, int):
raise TypeError(f"{self.protected_name} must be an integer")
if not (self.min_amount <= value <= self.max_amount):
raise ValueError(
f"{self.protected_name} "
f"must be between {self.min_amount} "
f"and {self.max_amount}")
setattr(instance, self.protected_name, value)

def __set_name__(self, owner: Any, name: str) -> None:
self.protected_name = "_" + name


class Visitor:
pass
def __init__(self, name: str, age: int, weight: int, height: int) -> None:
self.name = name
self.age = age
self.weight = weight
self.height = height


class SlideLimitationValidator(ABC):
pass


class ChildrenSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(4, 14)
height = IntegerRange(80, 120)
weight = IntegerRange(20, 50)


class AdultSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(14, 60)
height = IntegerRange(120, 220)
weight = IntegerRange(50, 120)


class Slide:
pass
def __init__(
self,
name: str,
limitation_class: SlideLimitationValidator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
limitation_class: SlideLimitationValidator
limitation_class: Type[SlideLimitationValidator]

) -> None:
self.name = name
self.limitation_class = limitation_class()

def can_access(self, visitor: Visitor) -> bool:
try:
self.limitation_class.age = visitor.age
self.limitation_class.height = visitor.height
self.limitation_class.weight = visitor.weight
except (TypeError, ValueError):
return False
return True
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def can_access(self, visitor: Visitor) -> bool:
try:
self.limitation_class.age = visitor.age
self.limitation_class.height = visitor.height
self.limitation_class.weight = visitor.weight
except (TypeError, ValueError):
return False
return True
def can_access(self, visitor: Visitor) -> bool:
try:
self.limitation_class(visitor.age, visitor.height, visitor.weight)
except (TypeError, ValueError):
return False
return True

Loading