Solution #628
Solution #628
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 The code effectively meets the core requirements, and the classes are well-structured for validating visitor access to slides. While there are a couple of minor issues, such as the type hint for limitation_class and the return type of the __get__ method, they don't significantly impact the functionality. Keep up the good work, and consider refining these areas for even better code quality in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __set_name__(self, owner: type, name: str) -> None: | ||
| self.protected_name = f"_{name}" | ||
|
|
||
| def __get__(self, instance: Any, owner: type) -> None: |
There was a problem hiding this comment.
The return type of the __get__ method should be Any instead of None. This method is expected to return the value of the attribute it manages.
| self, | ||
| name: str, | ||
| limitation_class: | ||
| type[SlideLimitationValidator] |
There was a problem hiding this comment.
There is a syntax error in the type hint for limitation_class. It should be Type[SlideLimitationValidator] instead of type[SlideLimitationValidator].
No description provided.