Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution cache decorator #1380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Psychox1k
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the caching decorator! 🎉 The code meets the task requirements effectively. Just a small note: be mindful of using non-hashable types as arguments since they can cause issues with the current cache key implementation. Keep up the great work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


def wrapper(*args) -> Any:

key = args

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation uses the args tuple directly as the cache key. This can lead to issues if the arguments are not hashable (e.g., lists). Consider converting the arguments to a hashable type or ensuring that only hashable types are used as arguments.


key = args

if key in storage_cache:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check if key in storage_cache assumes that the args tuple is a valid key. Ensure that all elements in args are hashable, or modify the key generation to handle non-hashable types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants