Solution #1382
Solution #1382
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets all the task requirements and constraints effectively. While there are some minor improvements suggested, such as checking if args not in cache_list: directly for efficiency and ensuring that keys in cache_list are immutable, these do not impact the core functionality. Keep up the excellent work and consider these suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -2,5 +2,15 @@ | |||
|
|
|||
|
|
|||
| def cache(func: Callable) -> Callable: | |||
| # Write your code here | |||
| pass | |||
| cache_list = {} | |||
There was a problem hiding this comment.
The cache_list dictionary is used to store cached results. However, using mutable types (like lists) as keys in a dictionary will raise a TypeError. Ensure that the arguments used as keys are immutable types, such as tuples.
| cache_list = {} | ||
|
|
||
| def storage(*args, **kwargs) -> int: | ||
| if args not in cache_list.keys(): |
There was a problem hiding this comment.
Checking if args not in cache_list.keys() is unnecessary. You can directly check if args not in cache_list: which is more efficient.
No description provided.