Solution #1383
Solution #1383
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets the task requirements and effectively optimizes function calls by caching results. While there are a couple of minor issues, such as handling non-hashable return types and updating the return type hint for the wrapper function, these do not significantly impact the functionality. Keep up the good work and consider these suggestions for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| cache_storage = {} | ||
|
|
||
| @wraps(func) | ||
| def wrapper(*args) -> Callable: |
There was a problem hiding this comment.
The wrapper function is expected to return a Callable, but it actually returns the result of the func, which may not be a Callable. Consider updating the return type hint to match the actual return type of the func.
| def long_time_func_2(n_tuple: tuple, power: int) -> int: | ||
| return [number ** power for number in n_tuple] |
There was a problem hiding this comment.
The long_time_func_2 function returns a list, which is not hashable and cannot be used as a cache key. Consider converting the list to a tuple before returning, or modify the caching mechanism to handle non-hashable return types.
No description provided.