Solution #1389
Solution #1389
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets the task requirements and effectively handles caching for functions with immutable arguments. While there are some minor points to consider, such as ensuring args is hashable and correctly checking each element's type, these don't impact the core functionality. Keep up the great work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| result = {} | ||
|
|
||
| def wrapper(*args) -> str: | ||
| if isinstance(args, (int, float, bool, str, tuple)): |
There was a problem hiding this comment.
The isinstance check is incorrect for args. args is a tuple, and this check will always return False. You should iterate over args and check each element instead.
|
|
||
| def wrapper(*args) -> str: | ||
| if isinstance(args, (int, float, bool, str, tuple)): | ||
| if args in result: |
There was a problem hiding this comment.
Checking args in result will not work as expected because args is a tuple of arguments. You need to ensure that the tuple itself is hashable and can be used as a key in the dictionary.
| return result[args] | ||
|
|
||
| new_result = func(*args) | ||
| result[args] = new_result |
There was a problem hiding this comment.
Ensure that args is hashable before using it as a key in the dictionary. If args contains unhashable elements, this will raise a TypeError.
No description provided.