Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution_v1.00' #1392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

DmytroPieskov
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Your implementation of the caching decorator is well done and meets the task requirements! 🎉 The functionality is correct, and you've ensured that the decorator handles multiple functions and prints the appropriate statements. The only minor suggestion is to adjust the return type hint of the wrapper function to be more flexible, such as using Any or removing it, to better match the decorated function's return type. Keep up the great work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

pass
cache_dict: dict = {}

def wrapper(*args) -> int:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type hint for the wrapper function is currently set to int. However, since this is a decorator, the return type should match the return type of the function it decorates. Consider changing the return type hint to Any or removing it altogether to make it more flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants