Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1395

wants to merge 1 commit into from

Conversation

GventBlade
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your implementation of the caching decorator is well done and meets the task requirements! 🎉 While there are a couple of minor issues with type annotations and import syntax, they don't impact the core functionality of your code. Keep up the great work, and consider refining those details for even better code quality in the future! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -1,6 +1,16 @@
from typing import Callable
from typing import Callable, Dict, Tuple, Any

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement has a syntax error due to the use of a forward slash instead of a comma. It should be from typing import Callable, Dict, Tuple, Any.

pass
cache_storage: Dict[Tuple, Any] = {}

def wrapper(*args) -> any:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type annotation any should be Any (with a capital 'A') to correctly use the type from the typing module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants