-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1400
base: master
Are you sure you want to change the base?
Solution #1400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the caching decorator! 🎉 Your code meets all the task requirements and constraints effectively. Just a couple of minor points to note: ensure you're using cache_result[args]
for dictionary access since args
is already a tuple, and remember to use Callable
with a capital 'C' for type hints. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
def cache(func: Callable) -> Callable: | ||
# Write your code here | ||
pass | ||
def cache(func: callable) -> Callable: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type hint for func
should be Callable
with a capital 'C'. The correct import from typing
is Callable
, not callable
.
|
||
def function_cache(*args) -> Any: | ||
if args not in cache_result: | ||
cache_result[*args] = func(*args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syntax cache_result[*args]
is incorrect for dictionary key assignment. It should be cache_result[args]
since args
is already a tuple.
print("Calculating new result") | ||
else: | ||
print("Getting from cache") | ||
return cache_result[*args] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the previous comment, use cache_result[args]
instead of cache_result[*args]
to access the cached result.
No description provided.