Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1402

wants to merge 1 commit into from

Conversation

Gudei
Copy link

@Gudei Gudei commented Nov 14, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the caching decorator! 🎉 The code meets all the task requirements and constraints, ensuring efficient caching and correct output messages. While there's a minor issue with the return type annotation of the wrapper function, it doesn't impact the functionality. Keep up the excellent work and consider updating the return type to Any for even better accuracy in the future. Well done! 👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

cache_storage = {}

@wraps(func)
def wrapper(*args: Any) -> Callable:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type annotation for the wrapper function should be Any instead of Callable, as the wrapper function returns the result of func(*args), which can be of any type, not necessarily a callable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants