Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement py-car-wash-station #1632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 41 additions & 4 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,45 @@
class Car:
# write your code here
pass
def __init__(self,
comfort_class: int,
clean_mark: int,
brand: str
) -> None:
self.comfort_class = comfort_class
self.clean_mark = clean_mark
self.brand = brand


class CarWashStation:
# write your code here
pass
def __init__(self,
distance_from_city_center: float,
clean_power: int,
average_rating: float,
count_of_ratings: int
) -> None:
self.distance_from_city_center = distance_from_city_center
self.clean_power = clean_power
self.average_rating = average_rating
self.count_of_ratings = count_of_ratings

def serve_cars(self, list_of_cars: list[Car]) -> float:
income = 0
for car in list_of_cars:
if car.clean_mark < self.clean_power:
income += self.calculate_washing_price(car)
self.wash_single_car(car)
return income

def calculate_washing_price(self, car: Car) -> float:
return round(
car.comfort_class * (self.clean_power - car.clean_mark)
* self.average_rating / self.distance_from_city_center, 1)
Comment on lines +33 to +35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a potential division by zero error in calculate_washing_price if distance_from_city_center is zero. Consider adding a check to prevent this scenario.


def wash_single_car(self, car: Car) -> None:
if self.clean_power > car.clean_mark:
car.clean_mark = self.clean_power

def rate_service(self, rate: int) -> None:
new_rate = ((self.average_rating * self.count_of_ratings)
+ rate) / (self.count_of_ratings + 1)
self.average_rating = round(new_rate, 1)
self.count_of_ratings += 1
Comment on lines +41 to +45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the rate parameter in rate_service is within a valid range (e.g., 1 to 5) to prevent invalid ratings from being processed.

Loading