Solution #1639
Solution #1639
Conversation
There was a problem hiding this comment.
Great job on implementing the Car and CarWashStation classes! 🎉 Your code meets the task requirements and performs the expected operations effectively. While there are a few minor issues related to code style and clean code practices, they do not impact the functionality of your solution.
Here are some suggestions for improvement:
- Code Style: Avoid using backslashes for line continuation in mathematical expressions. Instead, split expressions after binary operations for better readability.
- Clean Code: Consider removing unnecessary
elsestatements after acontinueto simplify your code. - Type Annotations: Ensure that you use the correct types in your method signatures, such as specifying
Carinstead oftypeand usingfloatfor parameters as needed.
Keep up the great work, and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,8 +1,50 @@ | |||
| import decimal | |||
There was a problem hiding this comment.
The decimal module is imported but not used correctly in the type annotations. You should use float for the average_rating parameter in the CarWashStation class, as specified in the task description.
| def __init__(self, comfort_class: int, clean_mark: int, brand: str) \ | ||
| -> None: |
There was a problem hiding this comment.
The line continuation character \ is not needed here. You can simply place the -> None: on the same line as the method signature.
| """method then return income of wash station and change clean_mark of car, | ||
| if clean_mark less than clean_power of wash station""" | ||
|
|
||
| def calculate_washing_price(self, car: type) -> decimal: |
There was a problem hiding this comment.
The type keyword is used incorrectly here. You should specify the type of car as Car instead of type.
| return round(wash_car_price, 1) | ||
| """method return washing price of single car""" | ||
|
|
||
| def wash_single_car(self, car: type) -> None: |
There was a problem hiding this comment.
Similar to the previous comment, the type keyword is used incorrectly. Specify the type of car as Car instead of type.
No description provided.