Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done #1650

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

done #1650

wants to merge 1 commit into from

Conversation

TymofiiKhlystik
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Car and CarWashStation classes! 🎉 Your code meets the task requirements and constraints, and you've done well to adhere to style guidelines. While there is a minor issue with duplicated logic in the serve_cars method, it doesn't impact the core functionality. To enhance your code, consider using the calculate_washing_price method within serve_cars to avoid redundancy. Keep up the good work and continue refining your skills! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +28 to +33
income = (
car.comfort_class
* (self.clean_power - car.clean_mark)
* self.average_rating
/ self.distance_from_city_center
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calculation of income in serve_cars duplicates the logic in calculate_washing_price. Consider calling calculate_washing_price(car) here to avoid redundancy and potential inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants