Develop #1805
Open
Develop #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsmutok
suggested changes
Sep 23, 2024
app/main.py
Outdated
Comment on lines
17
to
21
| counter = 0 | ||
| for i in range(len(phrase)): | ||
| if phrase[i].lower() in letter.lower(): | ||
| counter += 1 | ||
| return counter |
There was a problem hiding this comment.
Try to write it in one line
use count
EdAlekseiev
suggested changes
Sep 23, 2024
app/main.py
Outdated
Comment on lines
2
to
3
| return sum([1 for i in range(len(phrase)) | ||
| if phrase[i].lower() == letter.lower()]) |
There was a problem hiding this comment.
You should use method count of string.
https://www.w3schools.com/python/ref_string_count.asp
There was a problem hiding this comment.
i don`t understand
what i have do.
There was a problem hiding this comment.
You should improve your code with using method count of string. Something like this
Suggested change
| return sum([1 for i in range(len(phrase)) | |
| if phrase[i].lower() == letter.lower()]) | |
| return phrase.lower().count(letter.lower()) |
EdAlekseiev
suggested changes
Sep 23, 2024
app/main.py
Outdated
Comment on lines
2
to
3
| return sum([1 for i in range(len(phrase)) | ||
| if phrase[i].lower() == letter.lower()]) |
There was a problem hiding this comment.
You should improve your code with using method count of string. Something like this
Suggested change
| return sum([1 for i in range(len(phrase)) | |
| if phrase[i].lower() == letter.lower()]) | |
| return phrase.lower().count(letter.lower()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.