Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1886

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

'Solution' #1886

wants to merge 1 commit into from

Conversation

MagicAim
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the count_occurrences function correctly! 🎉 The function works as intended, counting occurrences in a case-insensitive manner. While there are some suggestions for improving variable names for clarity, these are minor and don't affect the functionality. Keep up the good work and consider these naming tips for future projects!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -14,4 +14,8 @@ def count_occurrences(phrase: str, letter: str) -> int:
:param letter: letter to find occurrences of it
:return: count occurrences of letter in phrase
"""
# write your code here
words = 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable words is not appropriately named. It would be clearer to name it count or occurrences to better reflect its purpose of counting occurrences.

@@ -14,4 +14,8 @@
:param letter: letter to find occurrences of it
:return: count occurrences of letter in phrase
"""
# write your code here
words = 0
for phrases in phrase:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable phrases is misleadingly named. It should be singular, like char or character, since it represents each character in the phrase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants