Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #724

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Develop #724

wants to merge 11 commits into from

Conversation

VASO304
Copy link

@VASO304 VASO304 commented Jul 26, 2023

нарешті, колупався з тим триклятим гітом 2 години, щоб прикрутити до пайчарму! тепер я задоволений собою і дивлюсь відоси далі

app/main.py Outdated
@@ -14,4 +14,12 @@ def count_occurrences(phrase: str, letter: str) -> int:
:param letter: letter to find occurrences of it
:return: count occurrences of letter in phrase
"""
# write your code here
count = 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count - could be better name

app/main.py Outdated
if char.lower() == letter.lower():
count += 1
return count
# new commit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra comments

app/main.py Outdated
count = 0

for char in phrase:
if char.lower() == letter.lower():

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put lower result to a separate var

@IvanRamyk IvanRamyk self-requested a review July 31, 2023 13:37
Copy link

@Y-Havryliv Y-Havryliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants