Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete task 1 #766

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

ruslan-sketch
Copy link

I am completed task 1. Please, take a review or give a new task.

Thanks!

Copy link

@vasylhnatiuk vasylhnatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
fix it

@ruslan-sketch
Copy link
Author

@vasylhnatiuk Привіт! Зустрів таку проблему, але ніде код не матюкається. Що робити?
image

app/main.py Outdated
Comment on lines 2 to 6
if letter.isupper():
phrase = phrase.upper()
else:
phrase = phrase.lower()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if letter.isupper():
phrase = phrase.upper()
else:
phrase = phrase.lower()
return phrase.lower().count(letter.lower())

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Василь привіт! чомусь не синхронізується Github з Mate academy. (@vsmutok)

Copy link

@ArsenPidhoretskyi ArsenPidhoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants