solution #387
Open
solution #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I made a cycling ref in the pages with detail from cars to driver and driver to cars |
pavlejviki
suggested changes
Aug 3, 2023
| CarListView,\ | ||
| DriverListView,\ | ||
| CarDetailView, \ | ||
| DriverDetailView |
There was a problem hiding this comment.
Avoid using \ as separator, use parentheses instead.
taxi/views.py
Outdated
| model = Manufacturer | ||
| template_name = "taxi/manufacturer_list.html" | ||
| context_object_name = "manufacturer_list" | ||
| queryset = Manufacturer.objects.all().order_by("name") |
There was a problem hiding this comment.
You can directly use the order_by method without calling .all()
templates/base.html
Outdated
| {% block content %}{% endblock %} | ||
| {% block content %} | ||
|
|
||
|
|
templates/includes/pagination.html
Outdated
| </li> | ||
| {% endif %} | ||
| </ul> | ||
| {% endif %} |
There was a problem hiding this comment.
Add a blank line at the end of the file
templates/taxi/car_detail.html
Outdated
| {% if driver.license_number %} {{ driver.license_number }} {% endif %} | ||
| </p> | ||
| {% empty %} | ||
| <p>No do not have Drivers Sorry :( </p> |
| {% block content %} | ||
| <h1> Information about our <strong>DRIVERS</strong></h1> | ||
| <br> | ||
| {% if driver_list %} |
| <h1> Manufacturer List</h1> | ||
| {% if manufacturer_list %} | ||
| <ul> | ||
| {% for manuf in manufacturer_list %} |
There was a problem hiding this comment.
manufacturer is
Suggested change
| {% for manuf in manufacturer_list %} | |
| {% for manufacturer in manufacturer_list %} | |
| {% else %} | ||
| <p> The are no manufacturer in Taxi Service</p> | ||
| {% endif %} | ||
| {% endblock %} |
templates/taxi/car_detail.html
Outdated
|
|
||
| {% block content %} | ||
| <h3>Information about car: {{ car.model }}</h3><br> | ||
| <h4>This cars manufacturer is: {{ car.manufacturer.name }}, from {{ car.manufacturer.country }}</h4> |
There was a problem hiding this comment.
Suggested change
| <h4>This cars manufacturer is: {{ car.manufacturer.name }}, from {{ car.manufacturer.country }}</h4> | |
| <h4>This car's manufacturer is: {{ car.manufacturer.name }}, from {{ car.manufacturer.country }}</h4> | |
templates/taxi/car_detail.html
Outdated
| {% extends 'base.html' %} | ||
|
|
||
| {% block content %} | ||
| <h3>Information about car: {{ car.model }}</h3><br> |
There was a problem hiding this comment.
Suggested change
| <h3>Information about car: {{ car.model }}</h3><br> | |
| <h3>Information about the car: {{ car.model }}</h3><br> | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.