Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #390

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #390

wants to merge 3 commits into from

Conversation

markus2812
Copy link

No description provided.

vsmutok
vsmutok suggested changes Aug 10, 2023
View reviewed changes
taxi/views.py Outdated
class ManufacturerListView(generic.ListView):
model = Manufacturer
context_object_name = "manufacturer_list"
queryset = Manufacturer.objects.all().order_by("name")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove redundant all()

taxi/views.py Outdated
class CarListView(generic.ListView):
model = Car
paginate_by = 5
queryset = Car.objects.all().select_related("manufacturer")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove redundant all()

templates/taxi/manufacturer_list.html Outdated
<p>There are no manufacturers</p>
{% endif %}
</ul>
{% endblock %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new empty line

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasylhnatiuk vasylhnatiuk vasylhnatiuk approved these changes

@vsmutok vsmutok Awaiting requested review from vsmutok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markus2812 @vsmutok @vasylhnatiuk