Solution #863
Solution #863
Conversation
There was a problem hiding this comment.
Great job on implementing the Django application! 🎉 The code is well-structured and meets all the core requirements of the task. While there are a few minor grammatical issues in the templates and a small spacing issue in the pagination links, these do not impact the functionality of your application. Keep up the good work, and consider addressing these minor issues to polish your project further. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
templates/includes/pagination.html
Outdated
| <ul class="pagination"> | ||
| {% if page_obj.has_previous %} | ||
| <li class="page-item"> | ||
| <a href="?page= {{ page_obj.previous_page_number }}" class="page-link">prev</a> |
There was a problem hiding this comment.
There is an extra space after ?page= in the href attribute. It should be ?page={{ page_obj.previous_page_number }} without the space to ensure the URL is correctly formed.
templates/includes/pagination.html
Outdated
|
|
||
| {% if page_obj.has_next %} | ||
| <li class="page-item"> | ||
| <a href="?page= {{ page_obj.next_page_number }}" class="page-link">next</a> |
There was a problem hiding this comment.
Similarly, there is an extra space after ?page= in the href attribute. It should be ?page={{ page_obj.next_page_number }} without the space.
templates/taxi/car_detail.html
Outdated
| {% for driver in car.drivers.all %} | ||
| <li>{{ driver.username }}</li> | ||
| {% empty %} | ||
| <p>Car haven't a drivers</p> |
There was a problem hiding this comment.
The message 'Car haven't a drivers' is grammatically incorrect. It should be 'Car doesn't have any drivers' or 'This car has no drivers.'
templates/taxi/car_list.html
Outdated
| {% for car in car_list%} | ||
| <li><a href="{% url 'taxi:car-detail' car.id %}">{{ car.model }}</a></li> | ||
| {% empty %} | ||
| <p>There is no car</p> |
There was a problem hiding this comment.
The message 'There is no car' is grammatically incorrect. It should be 'There are no cars' or 'No cars available.'
templates/taxi/driver_detail.html
Outdated
| {% for car in driver.cars.all %} | ||
| <li>{{ car.model }}</li> | ||
| {% empty %} | ||
| <p>Driver haven't a car</p> |
There was a problem hiding this comment.
The message 'Driver haven't a car' is grammatically incorrect. It should be 'Driver doesn't have any cars' or 'This driver has no cars.'
templates/taxi/driver_list.html
Outdated
| {% for driver in driver_list %} | ||
| <li><a href="{% url 'taxi:driver-detail' driver.id %}">{{ driver.first_name }}</a></li> | ||
| {% empty %} | ||
| <p>There is no drivers</p> |
There was a problem hiding this comment.
The message 'There is no drivers' is grammatically incorrect. It should be 'There are no drivers' or 'No drivers available.'
| {% for manufacturer in manufacturer_list%} | ||
| <li>{{ manufacturer.name }}: {{ manufacturer.country }}</li> | ||
| {% empty %} | ||
| <p>There is no manufacturers</p> |
There was a problem hiding this comment.
The message 'There is no manufacturers' is grammatically incorrect. It should be 'There are no manufacturers' or 'No manufacturers available.'
|
|
No description provided.