Solution #870
Solution #870
Conversation
CheshireKate
commented
Nov 14, 2024
CheshireKate
commented
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 While there are a few minor issues, such as the space in the pagination URL and the need to adjust some template tags, these do not significantly impact the functionality of your code. You've done well in setting up the views, URLs, and templates. Keep up the good work, and consider the feedback for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <ul class="pagination"> | ||
| {% if page_obj.has_previous %} | ||
| <li class="page-item"> | ||
| <a href="?page= {{ page_obj.previous_page_number }}" class="page-link">prev</a> |
There was a problem hiding this comment.
Remove the space after = in the href attribute to ensure the URL is correctly formed: href="?page={{ page_obj.previous_page_number }}".
|
|
||
| {% if page_obj.has_next %} | ||
| <li class="page-item"> | ||
| <a href="?page= {{ page_obj.next_page_number }}" class="page-link">next</a> |
There was a problem hiding this comment.
Remove the space after = in the href attribute to ensure the URL is correctly formed: href="?page={{ page_obj.next_page_number }}".
| {% if car %} | ||
| <p>{{ car.manufacturer }}</p> | ||
| <div><ul> | ||
| {% for driver in car.drivers.all %} |
There was a problem hiding this comment.
Ensure that car.drivers.all is a valid queryset. Typically, it should be car.drivers.all() to call the method and retrieve the related objects.
| {% block content %} | ||
| <ul> | ||
| {% for driver in drivers %} | ||
| <li><a href="{% url "taxi:driver-list"%}">{{ driver.username}}</a></li> |
There was a problem hiding this comment.
The URL tag should link to the driver detail view, not the driver list. Use {% url 'taxi:driver-detail' driver.id %} to link to the detail page for each driver.
| @@ -0,0 +1 @@ | |||
| {% extends "base.html" %} | |||
There was a problem hiding this comment.
Add a {% block content %} section to display the list of manufacturers. You can iterate over the manufacturers and create a list similar to other list templates.
