Develop #756
Open
Develop #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorkruz
suggested changes
Oct 9, 2024
Comment on lines
9
to
+10
| export const App: React.FC = () => { | ||
| const { name, born, died } = peopleFromServer[0]; | ||
| const [chosenPerson, setChosenPerson] = useState<Person | null>(null); |
|
|
||
| export const App: React.FC = () => { | ||
| const { name, born, died } = peopleFromServer[0]; | ||
| const [chosenPerson, setChosenPerson] = useState<Person | null>(null); | ||
| const [appliedQuery, setAppliedQuery] = useState(''); |
There was a problem hiding this comment.
Rename appliedQuery to searchQuery for clearer intent. This enhances readability and aligns better with related variables in your codebase.
| const [query, setQuery] = useState(''); | ||
| const [isFocused, setIsFocused] = useState(false); | ||
|
|
||
| const applyQuery = useCallback(debounce(changeAppliedQuery, delay), []); |
There was a problem hiding this comment.
you can include changeAppliedQuery and delay in the dependency array, this ensures that the debounce function updates correctly if changeAppliedQuery or delay changes.
Suggested change
| const applyQuery = useCallback(debounce(changeAppliedQuery, delay), []); | |
| const applyQuery = useCallback(debounce(changeAppliedQuery, delay), [changeAppliedQuery, delay]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK