solution #1674

AnatoliiLykhohodenko · 2023-07-25T15:47:55Z

anstsot

anstsot · 2023-07-26T08:15:14Z

src/App.tsx

-  <div className="App">
-    <h1>Dynamic list of Goods</h1>
+export const App: React.FC = () => {
+  const [preparedGoods, setPreparedGoods] = useState([] as Good[]);


Suggested change

const [preparedGoods, setPreparedGoods] = useState([] as Good[]);

const [preparedGoods, setPreparedGoods] = useState<Good[]>([]);

anstsot · 2023-07-26T08:15:29Z

src/App.tsx

+      <button
+        type="button"
+        data-cy="all-button"
+        onClick={() => getAll().then(setPreparedGoods)}


better to create separate functions

Suggested change

onClick={() => getAll().then(setPreparedGoods)}

onClick={onLoadAll}

YegorKorenkov

Please check point 3 in checklist and try to handle request error

anstsot

Good work, approving:sparkles:

solution

3743ba4

anstsot suggested changes Jul 26, 2023

View reviewed changes

fix

0ee516e

YegorKorenkov suggested changes Jul 27, 2023

View reviewed changes

fix

8741b11

anstsot approved these changes Aug 10, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

solution #1674

solution #1674

AnatoliiLykhohodenko commented Jul 25, 2023

anstsot left a comment

anstsot Jul 26, 2023

anstsot Jul 26, 2023

YegorKorenkov left a comment

anstsot left a comment

	const [preparedGoods, setPreparedGoods] = useState([] as Good[]);
	const [preparedGoods, setPreparedGoods] = useState<Good[]>([]);

	onClick={() => getAll().then(setPreparedGoods)}
	onClick={onLoadAll}

solution #1674

Are you sure you want to change the base?

solution #1674

Conversation

AnatoliiLykhohodenko commented Jul 25, 2023

anstsot left a comment

Choose a reason for hiding this comment

anstsot Jul 26, 2023

Choose a reason for hiding this comment

anstsot Jul 26, 2023

Choose a reason for hiding this comment

YegorKorenkov left a comment

Choose a reason for hiding this comment

anstsot left a comment

Choose a reason for hiding this comment