Solution #1196

ab3MN · 2024-11-13T10:30:20Z

polosanya

Good job! Let's improve your code a bit

polosanya · 2024-11-14T15:50:16Z

.eslintignore

@@ -1,2 +1,3 @@
 /build
 /node_modules
+/src


What's the purpose of it? It is better not to ignore eslint

polosanya · 2024-11-14T15:56:51Z

src/components/Posts/PostDetails/PostDetails.tsx

+  const [isFormOpen, setFormOpen] = useState(false);
+
+  useLayoutEffect(() => {
+    fetchComments();


Pay attention to the warning

polosanya · 2024-11-14T15:57:11Z

src/components/Posts/PostDetails/PostDetails.tsx

+          {isLoading && <Loader />}
+
+          {!isLoading && CommentsView}


Ternary operator can be used here

polosanya · 2024-11-14T16:00:15Z

src/components/Posts/PostList/PostListItem.tsx

+  post: Post;
+}
+
+const PostListItem: FC<PostListItemProps> = memo(({ post }) => {


Let's create a separate directory for this component

polosanya · 2024-11-14T16:01:05Z

src/components/Posts/PostList/PostList.tsx

+
+      <tbody>
+        {posts.map(post => (
+          <tr data-cy="Post" key={post.id}>


I guees this element should be inside PostItem component

polosanya · 2024-11-14T16:01:48Z

src/context/PostContext.tsx

+  const [selectedPost, setSelectedPost] = useState<Post | null>(null);
+  const { posts, postsError, isLoadingPosts } = usePosts(selectedUser);
+
+  const handleSelectUser = async (user: User) => {


polosanya · 2024-11-14T16:02:25Z

src/hooks/useComments.ts

+
+export const useComments = (postId: number) => {
+  const [comments, setComments] = useState<Comment[]>([]);
+  const [isLoading, setLoading] = useState(false);


Suggested change

const [isLoading, setLoading] = useState(false);

const [isLoading, setIsLoading] = useState(false);

polosanya · 2024-11-14T16:03:07Z

src/hooks/useComments.ts

+export const useComments = (postId: number) => {
+  const [comments, setComments] = useState<Comment[]>([]);
+  const [isLoading, setLoading] = useState(false);
+  const [isError, setError] = useState('');


Suggested change

const [isError, setError] = useState('');

const [error, setError] = useState('');

is prefix should be used only for boolean values

…have some problems with linter and without it I can't make a commit

…on submit button

StasSokolov1

Let's fix a few comments before approving, overall it looks good to me

StasSokolov1 · 2024-11-15T13:53:35Z

src/hooks/useCommentForm.ts

+  const [name, setName] = useState('');
+  const [email, setEmail] = useState('');
+  const [body, setBody] = useState('');


can we combine these three states into one, so we don't need three function for updates of name, email, body

StasSokolov1 · 2024-11-15T13:53:56Z

src/hooks/useCommentForm.ts

+  const handleChangeName = useCallback(
+    (event: ChangeEvent<HTMLInputElement>) => {
+      setName(event.target.value);
+
+      if (nameError) {
+        setNameError('');
+      }
+    },
+    [nameError],
+  );
+
+  const handleChangeEmail = useCallback(
+    (event: ChangeEvent<HTMLInputElement>) => {
+      setEmail(event.target.value);
+
+      if (emailError) {
+        setEmailError('');
+      }
+    },
+    [emailError],
+  );
+
+  const handleChangeBody = useCallback(
+    (event: ChangeEvent<HTMLTextAreaElement>) => {
+      setBody(event.target.value);
+
+      if (bodyError) {
+        setBodyError('');
+      }
+    },
+    [bodyError],
+  );


will be only one function after combine

StasSokolov1

LGTM!

ab3MN added 6 commits November 13, 2024 12:28

feat:implement solution

1bf8526

fix package.json

82b0aa4

fix package.json

bbd9e39

fix:fix eslint errors

7a65fa3

fix:fix eslint errors

010fe7a

fix:fix eslint errors

38f5c5d

polosanya suggested changes Nov 14, 2024

View reviewed changes

ab3MN added 3 commits November 14, 2024 20:22

fix:fixed all the comments,except remove src from eslintIgnore,cuz i …

f475627

…have some problems with linter and without it I can't make a commit

fix:fixed eslint errors

1af97d2

refactor:refacor handleAddComment and handleSubmitComment,fix loader …

41f6e1c

…on submit button

ab3MN requested a review from polosanya November 15, 2024 13:34

StasSokolov1 suggested changes Nov 15, 2024

View reviewed changes

refactor:refactor useCommentForm

cf4dd0d

ab3MN requested a review from StasSokolov1 November 15, 2024 14:57

StasSokolov1 approved these changes Nov 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solution #1196

Solution #1196

ab3MN commented Nov 13, 2024

polosanya left a comment

polosanya Nov 14, 2024

polosanya Nov 14, 2024

polosanya Nov 14, 2024

polosanya Nov 14, 2024

polosanya Nov 14, 2024

polosanya Nov 14, 2024

polosanya Nov 14, 2024

polosanya Nov 14, 2024

StasSokolov1 left a comment

StasSokolov1 Nov 15, 2024

StasSokolov1 Nov 15, 2024

StasSokolov1 left a comment

	const [isLoading, setLoading] = useState(false);
	const [isLoading, setIsLoading] = useState(false);

	const [isError, setError] = useState('');
	const [error, setError] = useState('');

Solution #1196

Are you sure you want to change the base?

Solution #1196

Conversation

ab3MN commented Nov 13, 2024

polosanya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StasSokolov1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StasSokolov1 left a comment

Choose a reason for hiding this comment