-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phone Catalog Mixelio #505
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried this problem with Loader solve |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "react_phone-catalog", | |||
"homepage": "react_phone-catalog", | |||
"homepage": "https://mixelio.github.io/react_phone-catalog", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might be the reason of problem, try this:
"homepage": "https://mixelio.github.io/react_phone-catalog", | |
"homepage": ".", |
package.json
Outdated
@@ -9,40 +9,52 @@ | |||
"@fortawesome/fontawesome-free": "^6.5.2", | |||
"bulma": "^1.0.1", | |||
"classnames": "^2.5.1", | |||
"jquery": "^3.7.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use it with react
}, | ||
"devDependencies": { | ||
"@cypress/react18": "^2.0.1", | ||
"@mate-academy/scripts": "^1.8.5", | ||
"@eslint/js": "^9.11.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is problem with npm install (peer dependencies) - try to fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed, but it got worse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have problems with deployment and packages installing ask for help in the chat or join a Q&A session - GitHub Pull Request is not a proper place to ask for help
Make sure it works and just then re-request the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to deploy your solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ
https://mixelio.github.io/react_phone-catalog/