Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone Catalog Mixelio #505

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Phone Catalog Mixelio #505

wants to merge 27 commits into from

Conversation

mixelio
Copy link

@mixelio mixelio commented Sep 22, 2024

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code

  1. Fix gap between the links
image
  1. Add a favicon and actual title on the page
image
  1. Where is the images here?
image
  1. There is no content here, need to fix it
image
  1. Add hover effects and actual address to your github profile for this link
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need to fix all comments from the previous review and make a deploy again after your changes
image

@mixelio
Copy link
Author

mixelio commented Sep 23, 2024

I have tried this problem with Loader solve

@@ -1,6 +1,6 @@
{
"name": "react_phone-catalog",
"homepage": "react_phone-catalog",
"homepage": "https://mixelio.github.io/react_phone-catalog",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be the reason of problem, try this:

Suggested change
"homepage": "https://mixelio.github.io/react_phone-catalog",
"homepage": ".",

package.json Outdated
@@ -9,40 +9,52 @@
"@fortawesome/fontawesome-free": "^6.5.2",
"bulma": "^1.0.1",
"classnames": "^2.5.1",
"jquery": "^3.7.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use it with react

},
"devDependencies": {
"@cypress/react18": "^2.0.1",
"@mate-academy/scripts": "^1.8.5",
"@eslint/js": "^9.11.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is problem with npm install (peer dependencies) - try to fix it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed, but it got worse

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have problems with deployment and packages installing ask for help in the chat or join a Q&A session - GitHub Pull Request is not a proper place to ask for help

Make sure it works and just then re-request the review

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to deploy your solution

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants