Develop #506
Open
Develop #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jv-aquino
suggested changes
Sep 23, 2024
There was a problem hiding this comment.
Hey Arthur, nice job! Your project is well-structured and really amazing - nice use of js and sass latest features btw!
There are some really smalll changes in regards to code and a small in regards to UI:
always use cursor: pointer for buttons for a11y reasons and for UX in general
| @@ -1 +1,20 @@ | |||
| // not empty | |||
| .App { | |||
| scroll-behavior: smooth; | |||
| <div className="App"> | ||
| <h1 className="h1Hidden">Product Catalog</h1> | ||
| <header className="header"> | ||
| <Header /> |
There was a problem hiding this comment.
i think it makes more sense for the
tag to be inside the header properly| ): Promise<ProductSpecs | undefined> { | ||
| const products = await getProducts(catId); | ||
|
|
||
| return products.find((p: ProductSpecs) => p.id === prodId); |
| width: 32px; | ||
| height: 100%; | ||
| border: 1px solid $c-icons; | ||
| background: url('../../../public/img/icons/chevron-right.svg') no-repeat |
There was a problem hiding this comment.
you could've created a basePath css variable
| midnightgreen: '#626B64', | ||
| midnight: '#31373F', | ||
| coral: '#F19584', | ||
| }; |
There was a problem hiding this comment.
also I think there are some variables/colors/infos like these that could be comprised in a folder like public/variables or something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://arthurfujii.github.io/react_phone-catalog/