Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone Catalog #516

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Igor-Yaremchuk
Copy link

DEMO LINK

I did this project together with: https://github.com/antonshtef

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks broken
image

fix it and then re-request the review

@TarasHoliuk
Copy link

  1. The current nav link has the wrong styles (also make links 100% height - same as header height, so it will be easier to click them. Same in the footer):

Figma:
image

App:
image

  1. In the cart and in the header you should show number of all items, not only unique items:

image

  1. Check font family here and in pagination:

image

  1. It makes sense to set 1st page on search change. Because now, if the 1st page (or for example 3rd or even 11th) is selected and I type "11" I can get results:

image

But if I select page 12 I see the page:

image

It's better than showing the same (12) page with no items, but it might confuse the user—it looks like no items match the search query at all.

  1. Add favicon and page title.

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Theme and language change 🔥
But a few things could be improved - see comments

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
The link to the category page doesn't work
Screenshot 2024-10-16 at 16 23 23
Screenshot 2024-10-16 at 16 25 05

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to remove the capacity

Screen.Recording.2024-10-16.at.16.55.30.mov
  1. this slider looks broken
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants