Process path within an explicit SVG namespace #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull-request, however, I fear this would break some code. Once the #179 regression tests are implemented, it will be easier to check for these things. Feel free to file an issue or re-open this pull-request if there's still an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first thanks a lot, your package is really fast and useful.
I am using an @evil-mad tool to generate paths from text and
pathnodes are generated with an explicit SVG namespace. (cf test file).I only fixed the path collection as I am not aware of performance implication but I can all of the
getElementsByTagName(a)bygetElementsByTagNameNS('http://www.w3.org/2000/svg', a)if you prefer.