Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Additional Info On ClassCard #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AdrianAndersen
Copy link
Collaborator

I have always envisioned the "Annet" category as something reserved for exciting events and special occasions.
Previously, events that had additional info were automatically assigned to the "Annet" category. This worked well for FSC Ski and 3T Fossegrenda (the homies), because they only added additional info on special occasions (pop-up events).

However, other locations (😤) use the additional info as a regular thing. Therefore, the "Annet" category is watered with "boring" normal classes on a lot of locations.

So how can we make the "Annet" category a special unicorn again?

Well, we can display the additional info directly on the ClassCard. That way, we get notified that there is some interesting info about the class, as well as keeping the "Annet" category clean.

Before

Screenshot 2024-05-16 at 23 24 49

After

Screenshot 2024-05-16 at 23 24 56

Since the additionalInfo is often long, it gets truncated. You can see the full text by hovering over the Chip, or opening the ClassInfo.

@AdrianAndersen
Copy link
Collaborator Author

Would be nice to see a little love for this one @mathiazom 😽

@mathiazom
Copy link
Owner

Would be nice to see a little love for this one @mathiazom 😽

Might be an unlucky example, but from the image it seems like the additional info is not very interesting. So I'm not sure it deserves the real estate 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature
Projects
Status: In Review 🕵️
Development

Successfully merging this pull request may close these issues.

2 participants