feat(crypto): pin identity when we withdraw verification #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4248 +/- ##
==========================================
+ Coverage 84.89% 84.90% +0.01%
==========================================
Files 274 274
Lines 29726 29727 +1
==========================================
+ Hits 25235 25240 +5
+ Misses 4491 4487 -4 ☔ View full report in Codecov by Sentry. |
uhoreg
force-pushed
the
pin_on_withdraw_verification
branch
from
df63ad5
to
5a22ab1
Compare
uhoreg
requested review from
Hywan and
andybalaam
and removed request for
a team
|
Please remember that we have a new way of adding changelog entries: https://github.com/matrix-org/matrix-rust-sdk/blob/main/CONTRIBUTING.md#writing-changelog-entries |
uhoreg
changed the title
uhoreg
force-pushed
the
pin_on_withdraw_verification
branch
from
89435ed
to
e6b5489
Compare
|
Can someone hit the merge button for me? I don't have permissions to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Withdrawing verification implicitly acknowledges that the identity changed, so we also pin the identity.
fixes #4206
Signed-off-by: