Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utd_hook): Report historical expected UTD with new reason #4275

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BillCarsonFr
Copy link
Member

Part of element-hq/element-meta#2581

Detect and report expected historical UTDs as such. Must be integrated by clients and reported with this code in Analytics.

To determine if an event is device historical (i.e sent before the current login existed) we use an heuristic based on the event origin_server_ts and the device creation local timestamp.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.05%. Comparing base (4724648) to head (0bc2a1a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4275      +/-   ##
==========================================
+ Coverage   85.03%   85.05%   +0.01%     
==========================================
  Files         274      274              
  Lines       29953    29964      +11     
==========================================
+ Hits        25471    25485      +14     
+ Misses       4482     4479       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BillCarsonFr BillCarsonFr marked this pull request as ready for review November 18, 2024 09:45
@BillCarsonFr BillCarsonFr requested review from a team as code owners November 18, 2024 09:45
@BillCarsonFr BillCarsonFr requested review from Hywan and richvdh and removed request for a team November 18, 2024 09:45
@BillCarsonFr BillCarsonFr marked this pull request as draft November 18, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant