fix(Room): Use subscribe_reset for subscribe_info (instead of just subscribe)
#4276
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
changed the base branch from
toger5/mock-matrix-server-widget-tests
to
main
toger5
force-pushed
the
toger5/subscribe-reset-for-room-info
branch
from
6514003
to
0fec0af
Compare
toger5
changed the title
toger5
changed the title
subscribe_reset for subscribe_info (instead of just subscribe)
bnjbvr
requested review from
a team
and removed request for
bnjbvr and
a team
bnjbvr
reviewed
Nov 18, 2024
|
Because this is an intentionally breaking change, we just adapt the tests right? |
|
Yes! Would need to make it super explicit that it's a breaking change, please have a look at our contribution guidelines :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
subscribe_infousers will most likely expect to get the info and not to wait for the next info change.Has been discussed with @bnjbvr.
Signed-off-by: