-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Use Python 3.12 for asyncio CI #16685
base: develop
Are you sure you want to change the base?
Conversation
Trying using uvloop has (fairly predictably) had no effect. |
@@ -226,6 +226,8 @@ pydantic = ">=1.7.4, <3" | |||
# needed. | |||
setuptools_rust = ">=1.3" | |||
|
|||
uvloop = ">=0.19.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the reactor tick timing stuff won't work with uvloop. I think I tried to support it briefly and then decided we probably weren't going to use it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful context! Was mainly wondering if using a different event loop would change how fast it'd run, but alas not. I guess there is just some extra overhead maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the asyncio reactor you end up doing some bookkeeping twice, which is annoying. I'm kind of surprised it is that much of a difference though, I wish we had a good benchmark for running this through instead of sytest.
Hopefully to make it faster?