Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Current way of detecting a connection in active txn is not robust #10015

Closed
1 task done
fengttt opened this issue Jun 13, 2023 · 1 comment
Closed
1 task done
Assignees
Labels
kind/bug Something isn't working needs-triage priority/p0 Critical feature that should be implemented in this version
Milestone

Comments

@fengttt
Copy link
Contributor

fengttt commented Jun 13, 2023

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Environment

- Version or commit-id (e.g. v0.1.0 or 8b23a93):
- Hardware parameters:
- OS type:
- Others:

Actual Behavior

#10000

The current way of detecting a connection in Txn is not robust. For example, the regular expression wont match something with comment like

begin /* this is my toy txn */;

See the discussion in the PR.

Expected Behavior

The we we detect active transaction is not robust enough. Is there anything more reliable from the protocol level? For example, when we plan to migrate a connection, can we issue a command to server to check if current connection is in transaction?

Assume connection migration is rare, and probably you HAVE TO migrate no matter what (due to CN crash/congestion etc), why don't we just simply abort current transaction and migrate?

Steps to Reproduce

No response

Additional information

No response

@fengttt fengttt added kind/bug Something isn't working priority/p0 Critical feature that should be implemented in this version needs-triage labels Jun 13, 2023
@fengttt fengttt added this to the 1.0.0 milestone Jun 13, 2023
@volgariver6
Copy link
Contributor

fixed by #10486

Now proxy gets txn status from OK packet or EOF packet which is received from server.

@volgariver6 volgariver6 assigned fengttt and unassigned volgariver6 Jul 7, 2023
@fengttt fengttt closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working needs-triage priority/p0 Critical feature that should be implemented in this version
Projects
None yet
Development

No branches or pull requests

2 participants