[bug] proxy: current way of detecting txn status is not robust #10486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volgariver6
requested review from
zhangxu19830126,
daviszhen,
jianwan0214 and
qingxinhome
as code owners
zhangxu19830126
approved these changes
Jul 7, 2023
daviszhen
approved these changes
Jul 7, 2023
Reason: current way of detecting a connection is in active txn or not is by parse the SQL statement from client. If it matches begin, commit or rollback, we change the txn status. This way is not robust, because the statement may contains some comment strings. Fix: check the txn status by the OK and EOF packet returned from server. Those packets contains the txn status. But currently, MO server does not set the status in OK and EOF packets correctly. So first, set the correty status in OK and EOF packets, then set the txn status in proxy session.
qingxinhome
approved these changes
Jul 7, 2023
This was referenced Jul 7, 2023
daviszhen
pushed a commit
to daviszhen/matrixone
that referenced
this pull request
Jul 21, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: current way of detecting a connection is in active txn or not is by parse the SQL statement from client. If it matches begin, commit or rollback, we change the txn status. This way is not robust, because the statement may contains some comment strings.
Fix: check the txn status by the OK and EOF packet returned from server. Those packets contains the txn status. But currently, MO server does not set the status in OK and EOF packets correctly. So first, set the correty status in OK and EOF packets, then set the txn status in proxy session.
What type of PR is this?
Which issue(s) this PR fixes:
issue #10015, #10164, https://github.com/matrixorigin/MO-Cloud/issues/957
What this PR does / why we need it: