embedding the s3-writer returned object stats to the batch the CN will commit to TN. #12780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouhongshen
requested review from
XuPeng-SH,
nnsgmsone,
triump2020,
m-schen and
LeftHandCold
as code owners
gouhongshen
force-pushed
the
adding_object_stats_to_batch
branch
from
42b903c
to
b6c2a7c
Compare
matrix-meow
added
size/M
matrix-meow
added
size/L
nnsgmsone
reviewed
Nov 20, 2023
m-schen
approved these changes
Nov 20, 2023
nnsgmsone
approved these changes
Nov 20, 2023
LeftHandCold
approved these changes
Nov 21, 2023
XuPeng-SH
approved these changes
Nov 21, 2023
gavinyue
pushed a commit
to gavinyue/matrixone
that referenced
this pull request
Nov 30, 2023
…l commit to TN. (matrixorigin#12780) 1. summary in some cases, the CN will write S3 directly. after the writer is done, it has all the metadata of this object which can be reused later to avoid reloading object metadata from disk. this PR enables the writer to construct an `object stats` when an object has been written down, and embedding these `stats` to the batch the CN will commit to TN. and replaced part of the block info with this object stats in ranges. Approved by: @m-schen, @nnsgmsone, @LeftHandCold, @XuPeng-SH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #12696
#10371
What this PR does / why we need it:
in some cases, the CN will write S3 directly. after the writer is done, it has all the metadata of this object which can be reused later to avoid reloading object metadata from disk.
this PR enables the writer to construct an
object statswhen an object has been written down, and embedding thesestatsto the batch the CN will commit to TN.and replaced part of the block info with this object stats in ranges.