-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage READ/WRITE support for LOAD DATA, External Table and SELECT OUTFILE #17979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…QL by InternalSqlExecutor
…al' but actual 'Etc/UTC'
cpegeric
requested review from
m-schen,
ouyuanning,
aunjgr,
badboynt1,
daviszhen,
qingxinhome,
aressu1985 and
heni02
as code owners
August 8, 2024 15:41
cpegeric
requested review from
zhangxu19830126,
XuPeng-SH,
fengttt,
volgariver6,
LeftHandCold,
jiangxinmeng1,
reusee,
triump2020,
aptend,
xzxiong,
iamlinjunhong,
w-zr,
sukki37 and
dengn
as code owners
August 21, 2024 20:00
matrix-meow
added
size/L
Denotes a PR that changes [500,999] lines
and removed
size/XXL
Denotes a PR that changes 2000+ lines
labels
Aug 21, 2024
m-schen
approved these changes
Aug 22, 2024
不知道为什么file changed里多了特别多main分支上的改动,我担心这会带来麻烦。 所以我先加了个not-merge的标签,如果检查没问题的话可以去掉。pr会被正常合并。 |
没有问题,这应该不会引入新的commit或者带来code owner的改动。 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug fix
Enhancement
kind/bug
Something isn't working
kind/feature
Review effort [1-5]: 4
size/L
Denotes a PR that changes [500,999] lines
Tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
What type of PR is this?
Which issue(s) this PR fixes:
issue #17820
issue #17747
issue #17748
What this PR does / why we need it:
PR Type
Bug fix, Enhancement, Tests
Description
compileExternScan
, file existence checks, and external stats initialization.stage_list
built-in function and added corresponding function ID.Changes walkthrough 📝
12 files
export.go
Refactor export logic for file handling and CSV writing.
pkg/frontend/export.go
io.Pipe
andfileservice
.openNewFile
function.stage_util.go
Add utility functions for stage URL handling and file listing.
pkg/sql/plan/function/stage_util.go
authenticate.go
Refactor stage creation and alteration logic.
pkg/frontend/authenticate.go
utils.go
Add initialization functions for stage and S3 parameters.
pkg/sql/plan/utils.go
func_unary.go
Add `StageList` function for listing stage files.
pkg/sql/plan/function/func_unary.go
StageList
function to list files in a stage.list_builtIn.go
Register `stage_list` built-in function.
pkg/sql/plan/function/list_builtIn.go
stage_list
function to the list of built-in functions.compile.go
Enhance `compileExternScan` to support stage URLs.
pkg/sql/compile/compile.go
compileExternScan
to handle stage URLs.query_result.go
Update query result dumping to use new export logic.
pkg/frontend/query_result.go
function_id.go
Add function ID for `STAGE_LIST`.
pkg/sql/plan/function/function_id.go
STAGE_LIST
function ID.status_stmt.go
Use refactored export logic in status statement execution.
pkg/frontend/status_stmt.go
build_load.go
Enhance file existence check to support stage URLs.
pkg/sql/plan/build_load.go
external.go
Enhance external stats initialization for stage URLs.
pkg/sql/plan/external.go
12 files
authenticate_test.go
Update test cases for stage creation and alteration.
pkg/frontend/authenticate_test.go
export_test.go
Update export tests to match refactored logic.
pkg/frontend/export_test.go
session_test.go
Comment out failing test case for system time zone.
pkg/frontend/session_test.go
nonsys_restore_system_table_to_nonsys_account.result
Update snapshot test results with new timestamps and credentials.
test/distributed/cases/snapshot/nonsys_restore_system_table_to_nonsys_account.result
restore_cluster_table.result
Update cluster restore test results with new timestamps and
credentials.
test/distributed/cases/snapshot/cluster/restore_cluster_table.result
cluster_level_snapshot_restore_system_table_to_nonsys.result
Update snapshot and stage details with new timestamps and formats
test/distributed/cases/snapshot/cluster_level_snapshot_restore_system_table_to_nonsys.result
sys_restore_system_table_to_nonsys_account.result
Update snapshot and stage details with new timestamps and formats
test/distributed/cases/snapshot/sys_restore_system_table_to_nonsys_account.result
sys_restore_system_table_to_newnonsys_account.result
Update snapshot and stage details with new timestamps and formats
test/distributed/cases/snapshot/sys_restore_system_table_to_newnonsys_account.result
stage.result
Add and update stage creation and data loading tests
test/distributed/cases/stage/stage.result
load_data_parquet.result
Add tests for loading data from parquet files
test/distributed/cases/load_data/load_data_parquet.result
load_data_parquet.sql
Add SQL commands for loading data from parquet files
test/distributed/cases/load_data/load_data_parquet.sql
files.
stage.sql
Update stage SQL tests for new URL formats and sub-stages
test/distributed/cases/stage/stage.sql
CREATE STAGE
statements with various URL formats, includingfile://
,s3://
, andstage://
.ALTER STAGE
statements to reflect new URL formats andcredentials.
SELECT INTO OUTFILE
statements to use stage URLs.sub-stages.